bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: uniq/sort documentation flaw


From: Jim Meyering
Subject: Re: uniq/sort documentation flaw
Date: Tue, 05 May 2009 17:19:34 +0200

Pádraig Brady wrote:
> Jim Meyering wrote:
>>
>> Thanks.
>> One suggestion:
>>
>>> From: =?utf-8?q?P=C3=A1draig=20Brady?= <address@hidden>
>>> diff --git a/src/uniq.c b/src/uniq.c
>>> -Discard all but one of successive identical lines from INPUT (or\n\
>>> -standard input), writing to OUTPUT (or standard output).\n\
>>> +Filter adjacent matching lines from INPUT (or standard input),\n\
>>> +writing to OUTPUT (or standard output).\n\
>
>> That can be read as removing all lines that match.
>> I'd like it to say clearly that one of the lines remains.
>> How about this?
>>
>>   Discard all but one of a sequence of matching lines from INPUT (or\n\
>>   standard input), writing to OUTPUT (or standard output).\n\
>>
>
> Well actually the full hunk was:
>
> -Discard all but one of successive identical lines from INPUT (or\n\
> -standard input), writing to OUTPUT (or standard output).\n\
> +Filter adjacent matching lines from INPUT (or standard input),\n\
> +writing to OUTPUT (or standard output).\n\
> +\n\
> +With no options, matching lines are merged to the first occurrence.\n\
>
> But if you want the first line to describe only the default
> mode of operation of uniq, then I'll change it to:

Actually, now that I reread it, realizing that the wording
is intended to be broad enough to describe more of uniq's
functionality, I prefer your way.

You're welcome to commit your original.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]