bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: uniq/sort documentation flaw


From: Pádraig Brady
Subject: Re: uniq/sort documentation flaw
Date: Tue, 5 May 2009 16:03:55 +0100
User-agent: Thunderbird 2.0.0.6 (X11/20071008)

Jim Meyering wrote:
> 
> Thanks.
> One suggestion:
> 
>> From: =?utf-8?q?P=C3=A1draig=20Brady?= <address@hidden>
>> diff --git a/src/uniq.c b/src/uniq.c
>> -Discard all but one of successive identical lines from INPUT (or\n\
>> -standard input), writing to OUTPUT (or standard output).\n\
>> +Filter adjacent matching lines from INPUT (or standard input),\n\
>> +writing to OUTPUT (or standard output).\n\

> That can be read as removing all lines that match.
> I'd like it to say clearly that one of the lines remains.
> How about this?
> 
>   Discard all but one of a sequence of matching lines from INPUT (or\n\
>   standard input), writing to OUTPUT (or standard output).\n\
> 

Well actually the full hunk was:

-Discard all but one of successive identical lines from INPUT (or\n\
-standard input), writing to OUTPUT (or standard output).\n\
+Filter adjacent matching lines from INPUT (or standard input),\n\
+writing to OUTPUT (or standard output).\n\
+\n\
+With no options, matching lines are merged to the first occurrence.\n\

But if you want the first line to describe only the default
mode of operation of uniq, then I'll change it to:

-Discard all but one of successive identical lines from INPUT (or\n\
-standard input), writing to OUTPUT (or standard output).\n\
+Discard all but one of a sequence of matching lines from INPUT (or\n\
+standard input), writing to OUTPUT (or standard output).\n\

cheers,
Pádraig.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]