Re: coreutils 7.1.49-ebb9 FTB sparc/Solaris, AIX

[Matthew Woehlke]

(Please don't miss the AIX error at the bottom that isn't another 
decl-after-stmt.)

Jim Meyering wrote:
> Thanks for the report.
> That's a statement-before-decl:
> [snip]

It's not be the only one.

Ok, first, we'll try the patch:
patching file remove.c
Hunk #1 succeeded at 284 (offset 22 lines).
Hunk #3 succeeded at 875 (offset 39 lines).
Hunk #5 succeeded at 969 (offset 39 lines).
Hunk #6 succeeded at 1736 (offset 186 lines).
Hunk #7 succeeded at 1612 (offset 39 lines).
Hunk #8 succeeded at 1778 (offset 186 lines).
patching file rm.c
Hunk #1 succeeded at 353 (offset -1 lines).
patching file seq.c
Hunk #1 succeeded at 161 (offset -2 lines).
Hunk #3 FAILED at 348.
Hunk #4 succeeded at 329 (offset -27 lines).
Hunk #5 FAILED at 418.
Hunk #6 FAILED at 426.
3 out of 6 hunks FAILED -- saving rejects to file seq.c.rej
patching file shred.c

So... remaining (decl-after-stmt) problems:

"copy.c", line 2201.3: 1506-275 (S) Unexpected text 'signed char' 
encountered.

"du.c", line 919.3: 1506-275 (S) Unexpected text 'struct' encountered.
"du.c", line 951.3: 1506-275 (S) Unexpected text 'char' encountered.

"ls.c", line 3645.3: 1506-046 (S) Syntax error.
"ls.c", line 3844.3: 1506-046 (S) Syntax error.
"ls.c", line 3895.3: 1506-046 (S) Syntax error.

"sort.c", line 2721.7: 1506-046 (S) Syntax error.
"sort.c", line 2722.7: 1506-046 (S) Syntax error.
"sort.c", line 2723.7: 1506-275 (S) Unexpected text 'char' encountered.

"wc.c", line 644.3: 1506-275 (S) Unexpected text 'signed char' encountered.
"wc.c", line 645.3: 1506-275 (S) Unexpected text 'struct' encountered.
"wc.c", line 672.7: 1506-275 (S) Unexpected text 'struct' encountered.
"wc.c", line 704.3: 1506-275 (S) Unexpected text 'int' encountered.

"seq.c", line 324.11: 1506-046 (S) Syntax error.

(The patch also created an imbalanced } in seq.c a few lines later, but 
that's easily fixed by fixing the patch.)

Time to say "I told you so" yet? ;-) 
(<http://permalink.gmane.org/gmane.comp.lib.gnulib.bugs/16689> and 
elsewhere in the thread...) Apparently "maybe not ever" was defined as 
"before this week" :-). I've been updating my toolchains across the 
board. And... so far coreutils has been the only major c89-violator.

Actually, I am a little confused, configure picked '-qlanglvl=ansi' but 
'stdc99' and 'extc99' are available. (But I don't think that helps 
sparc/Solaris for which my only compilers - including gcc, apparently - 
are ancient.)

Also, here is a different (AIX-only) error:

cc -qlanglvl=ansi -qlanglvl=ansi   -g   -o ln ln.o libver.a 
../lib/libcoreutils.a /home/install/gnu/rs6000_aix/lib/libintl.a 
-lpthread -lc ../lib/libcoreutils.a
source='ls.c' object='ls.o' libtool=no \
        DEPDIR=.deps depmode=aix /bin/sh ../build-aux/depcomp \
        cc -qlanglvl=ansi -qlanglvl=ansi  -I. -I../lib  -I../lib 
-I/home/install/gnu/rs6000_aix/include   -g -c ls.c
"ls.c", line 715.8: 1506-112 (E) Duplicate type qualifier "volatile" 
ignored.
"ls.c", line 719.8: 1506-112 (E) Duplicate type qualifier "volatile" 
ignored.
make[3]: *** [ls.o] Error 1

I just ran into this also with some other package (possibly gettext or 
subversion*); might call for a fix at a higher level (gnulib or 
autoconf?). sig_atomic_t is already volatile on AIX (I checked last 
time) so the extra 'volatile' should just be dropped. Maybe something like:

#if SIG_ATOMIC_T_IS_VOLATILE
#define SIG_ATOMIC_T_VOLATILE sig_atomic_t
#else
#define SIG_ATOMIC_T_VOLATILE volatile sig_atomic_t
#endif

(...and the appropriate configure check, and obvious 
declaration-replacements.)

(* zgrep 'volatile sig_action' *.tar.gz says: Python, cmake, coreutils, 
gettext, m4, ncurses, subversion, tcsh, wget.)

--
Matthew
Please do not quote my e-mail address unobfuscated in message bodies.
--
"Two IIRC's must make a right" -- Larry Hall (paraphrased)