Re: [PATCH] factor.c (NDEBUG): Define this before including <assert.h>, not after.

[Jim Meyering]

Eric Blake wrote:
>> coreutils/src/factor.c #defines NDEBUG after including <assert.h>.
>> It's supposed to be defined before.
>
> Why is factor.c even messing with NDEBUG?  The point of the gnulib assert
> module is to allow ./configure-time control over whether assertions
> are enabled, and this patch would mean that for this file, the user
> no longer has control over that option.

I suspect that I added it to disable an assertion that was
deemed too expensive for general use.  The two remaining
ones are nothing to worry about, so I had no qualms about
removing it.