Re: [PATCH] Replacement for the sigs_to_ignore hack in timeout.c

[Pádraig Brady]

Pádraig Brady wrote:
> Giuseppe Scrivano wrote:
>> Hello,
>>
>> what do you think about the following way to remove the sigs_to_ignore
>> hack in the timeout.c file?
>> It ignores temporarily the signal inside the `send_sig' function instead
>> of using the `sigs_to_ignore' array.
> 
> I'll test this tonight, as this stuff is tricky.

I tested it and couldn't break it,
though I'm worried about this change.

The code it replaces is very simple and explicit.
Whereas I'm worried about the implicit behaviour
of the new code. Specifically I'm worried about
races, where the monitor process may not receive
(and ignore) the signal before the signal handler
is reinstated. I.E. are we always guaranteed that
kill() is synchronous and will not return until
all signals have been delivered to all members of group?

thanks,
Pádraig,