bug-coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Options --enable{,-no}-install-program


From: James Youngman
Subject: Re: Options --enable{,-no}-install-program
Date: Sun, 27 Jan 2008 00:44:01 +0000

On Jan 26, 2008 11:31 PM, Eric Blake <address@hidden> wrote:

[ "unknown group --" ]

> Huh?  That's been fixed for some time now (Sept 2006):
> http://git.sv.gnu.org/gitweb/?p=coreutils.git;a=commitdiff;h=b7c315c

Yes, sorry, I was confusing /usr/bin/groups and ./groups.


> | -    print_user (use_real ? ruid : euid);
> | +    {
> | +      print_user (use_real ? ruid : euid);
> | +    }
>
> Why are you making these cosmetic changes, with no other change in the
> code?  GNU Coding Standards recommend eliding the braces for single-line
> statements (yes, it is a style that not everyone likes, because you then
> have to remember to add braces if you add a statement, but consistency
> looks nicer).

It's just that I preffered

if (condition)
  {
     compound
   }
else
  {
  foo
  }
else
  {
     compound
  }


... to ...

if (condition)
  {
     compound
   }
else
  foo
else
  {
     compound
  }




reply via email to

[Prev in Thread] Current Thread [Next in Thread]