Re: Options --enable{,-no}-install-program

[Jim Meyering]

"James Youngman" <address@hidden> wrote:

> On Jan 8, 2008 5:46 PM, Jim Meyering <address@hidden> wrote:
>
>> If you're really motivated, there's another minor problem:
>> the include/exclude mechanism operates only on bin_PROGRAMS,
>> and not bin_SCRIPTS.  That means --enable-no-install-program=groups
>> doesn't work, since "groups" is a script.
>
> I had a go at this and didn't come up with a result I found pleasing.
> So instead I took a sledgehammer to the walnut.  The patch is attached
> (sorry, but it's safer that way because of my non-configurable
> tab-mangling mail client) and the ChangeLog entry is appended.
> Please note that I added a NEWS file entry; no doubt you will need to
> fix the version number in there, the file format demands one but I had
> no idea what to use.
>
> If you don't like the change, let me know and I'll resubmit just the
> segv fix as a separate patch.
>
> Thanks,
> James.
>
> 2008-01-25  James Youngman  <address@hidden>
>
>         Replace groups.sh with groups.c.
>         * src/groups.c (main): New file, replacing groups.sh.
>         * src/group-list.c, src/group-list.h: New files, factored out of id.c,
>         implementing the functionality that "id" and "groups" have in common.
>         * src/id.c (print_full_info): Avoid a segfault when trying to print
>         an error message if getgroups fails.
>         (print_group_list): Move to group-list.c.
>         (print_group): Likewise.
>         * man/Makefile.am: When building groups.1, obtain the help text
>         from src/groups.c, not src/groups.sh.
>         * doc/coreutils.texi (groups: Print group names a user is in):
>         Explain why "groups" and "groups $(id -un)" give different results
>         in existing login sessions after you change the group database.
>         (id: Print user identity): Likewise for "id".

Good idea!
Thanks for working on this.
I'll take a look in the next few days.