Re: Coreutils 5.0.1: spurious error from uniq

[Andreas Schwab]

Paul Eggert <address@hidden> writes:

|> Anyway, it's still possible that 'uniq' has a bug, or perhaps
|> 'strcoll', depending on your further investigation.

It _is_ a bug in coreutils, not in strcoll:

- AC_CHECK_FUNCS(strcoll) is missing,
- the fallback implementation of memcoll using memcmp does not clear
  errno.

Andreas.

2003-07-18  Andreas Schwab  <address@hidden>

        * memcoll.c (memcoll) [!HAVE_STRCOLL]: Clear errno.

--- coreutils-5.0.1/lib/memcoll.c.~1~   2003-06-06 22:11:58.000000000 +0200
+++ coreutils-5.0.1/lib/memcoll.c       2003-07-18 11:58:37.000000000 +0200
@@ -83,6 +83,7 @@ memcoll (char *s1, size_t s1len, char *s
   diff = memcmp (s1, s2, s1len < s2len ? s1len : s2len);
   if (! diff)
     diff = s1len < s2len ? -1 : s1len != s2len;
+  errno = 0;
 
 #endif
 

2003-07-18  Andreas Schwab  <address@hidden>

        * jm-macros.m4 (jm_MACROS): Check for strcoll.

--- coreutils-5.0.1/m4/jm-macros.m4.~1~ 2003-07-12 20:46:46.000000000 +0200
+++ coreutils-5.0.1/m4/jm-macros.m4     2003-07-18 11:55:06.000000000 +0200
@@ -173,6 +173,7 @@ AC_DEFUN([jm_MACROS],
     realpath \
     sethostname \
     strchr \
+    strcoll \
     strerror \
     strrchr \
     sysctl \

-- 
Andreas Schwab, SuSE Labs, address@hidden
SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."