Re: bison-2.4.2 broken on FreeBSD

[Joel E. Denny]

On Tue, 23 Mar 2010, Johan van Selst wrote:

> Joel E. Denny wrote:
> > On Tue, 23 Mar 2010, Johan van Selst wrote:
> > > P.S. The 'make check' step only works with GNU make however (this
> > > probably has been so for ages, but I don't generally run make check
> > > and the regular compilation works fine with BSD make).
> > Off the top of my head, I can't think of a reason for this.  What does
> > the failure look like?
> 
>   ...
>   make  check-local
>   make: don't know how to make package.m4. Stop
>   *** Error code 2
>   Stop in /usr/home/johans/git/bison-2.4.3/tests.

Fortunately, package.m4 is included in our release tarballs, so I think 
this is only a problem when building from git.

> The full output of './configure; make; make check' I have put online
> at http://www.stack.nl/~johans/bison-make-check-log.txt

My connection to that server keeps timing out, so I can't see the log.

> But running gmake just once seems to fix it: If I later run 'make check'
> with BSD make again, it will run all tests just fine.

We usually do aim at portable make files, and the fix might be easy.  
Does the following work for you?  Of course, you'll need to delete at 
least tests/package.m4 before testing.

diff --git a/tests/Makefile.am b/tests/Makefile.am
index 13516af..6c921f2 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -56,7 +56,7 @@ TESTSUITE_AT = \
 TESTSUITE = $(srcdir)/testsuite
 
 AUTOTEST = $(AUTOM4TE) --language=autotest
-$(TESTSUITE): package.m4 $(TESTSUITE_AT)
+$(TESTSUITE): $(srcdir)/package.m4 $(TESTSUITE_AT)
        $(AUTOTEST) -I $(srcdir) testsuite.at -o address@hidden
        mv address@hidden $@