Re: push parser

[Joel E. Denny]

On Fri, 8 Dec 2006, Bob Rossi wrote:

> Here's a patch that renames all uses of pv to pstate. It changes all
> uses of pvars to pstate. It also adds the prototypes for yypstateinit
> and yypushparse to the bison generated header file.

Thanks, but I just noticed that your local variable pstate (formerly pv) 
intrudes on the user namespace.  All Bison names should be in the yy (or 
YY for most macros) namespace.  To eliminate another renaming patch, could 
you just rewrite this one?  As long as you're working on that, do you 
agree with my earlier suggestion to use underscores between words for 
legibility?

  yypstate_init
  yypush_parse

If so, can we just get all of this renaming done at the same time?

> I'm not really sure how to write a ChangeLog entry whening doing mass
> renames, so hopefully this is OK.

I'm not sure either, but the following seems more in line with what I've 
seen:

2006-12-08  Bob Rossi  <address@hidden>

        * data/push.c: (yypvarsinit, yypvars, struct yypvars): Rename to...
        (yypstateinit, yypstate, struct yypstate): ... these and update all
        uses.
        (b4_yyssa, b4_yyerror_range, yypstate_init, yypushparse): Rename pv to 
        pstate.
        (yypstateinit, yypushparse): Declare in Bison-generated header file.
        * tests/calc.at (_AT_DATA_CALC_Y): Use newly named functions.

Sorry, I didn't update it to include my suggestions above.  Hopefully Paul 
will step in if this is way off.

Also, I think Paul likes to see Bison with a capital B unless you're 
writing literal code with the name of the executable.