Re: push parser

[Paul Eggert]

Bob Rossi <address@hidden> writes:

>> I have a small patch that get's me this far:
>>   status = yypushparse (ctx, ch, &yylval);
>> 
>> What should I do about yylval?

Sorry, I don't understand the question; perhaps you meant yyloc?

>> I can attempt to make yypushparse have an extra parameter when locations
>> are enabled. Does that sound correct?

Yes, that sounds fine.

> Here, is a patch I'm posting just for you to tell me if this is the
> appropriate solution.

Sorry, I'm a bit lost.  That patch modifies yacc.c and puts a bunch of
push-parser stuff in it; but yacc.c differs from push.c afterwards.
Is this intended?  I thought the patch would just affect push.c.

The push.c patch looks OK, except there still seems to be some
confusion about YYLTYPE_IS_TRIVIAL versus b4_locations_if.
YYLTYPE_IS_TRIVIAL is defined if it is known that YYLTYPE is a trivial
type (in the C++ sense: it's just a bunch of bytes).  But in the patch
YYLTYPE_IS_TRIVIAL seems to be used for some other purpose.