Re: push parser implemenation

[Paul Eggert]

Bob Rossi <address@hidden> writes:

> What's the minimum percentage of lost time that could be afforded in
> order for me to merge the push skeleton into the yacc skeleton?

I'd like it to be low -- in the 1% or less range, anyway.

>> OK, but I'd rather not make copies, but instead would rather reuse the
>> original tests but make them parameterized.  But that should be fairly
>> easy.
>
> I'm sorry, I'm not exactly sure what you mean here. 

The test suite is generated by Autotest.  It's a bunch of macro calls.
Test cases are often generated by invoking a macro, with some arguments.
You should be able to generate push-parser test cases by invoking
those same macros (perhaps with slightly different args).  So
there shouldn't be all that much change to the source code, even
if the testsuite script grows a bit.

> Should I be
> modifing the bison/tests/testsuite sh file?

You should be modifying the files that are checked into CVS,
not the files that are generated from those.

> Running the push parser on a test takes the basicaly the same amount
> of time to run the pure parser.  There is only 3 pure tests for the
> yacc.c skeleton it looks like. Should I continue to test those 3
> tests using the pure parser, and then run the same test using the
> push parser option intead?

Yes, that sounds right.