Re: push parser implemenation

[Bob Rossi]

On Sat, Apr 08, 2006 at 02:58:45PM -0400, Bob Rossi wrote:
> On Fri, Apr 07, 2006 at 02:42:29PM +0200, Akim Demaille wrote:
> > Bob,
> > 
> > I'm starting to toy with your implementation, and to try to bench it.
> > It seems that there is about a 15% performance loss of push.c compared
> > to yacc.c, both used in pull mode without compiler optimization on my
> > Mac.
> 
> You know, it would be possible to only create the structure for the push
> parser mode, and to leave all variables declared in yyparse for normal
> mode and for pure mode. This would be more m4 magic, but would fix the
> performance problems.
> 
> I wrote it the way it is now because it was cleaner. I only had to do m4
> magic for 'pv->yychar' vs 'yychar' for the 4 user visible variables
> (instead of all the variables), because all 3 versions used the structure.
> 
> What do you think?

Is this something I should do?

Thanks,
Bob Rossi