[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: failure to call copy_character
From: |
Akim Demaille |
Subject: |
Re: failure to call copy_character |
Date: |
14 May 2002 12:23:50 +0200 |
User-agent: |
Gnus/5.0808 (Gnus v5.8.8) XEmacs/21.4 (Common Lisp) |
>>>>> "Florian" == Florian Krohm <address@hidden> writes:
>> | | case '{': | - obstack_1grow (&action_obstack, c); | +
>> copy_character (&action_obstack, c); | ++count; | break;
>>
>> These two are quite useless, but it is safer, so do as you want wrt
>> this one.
>>
Florian> Yes, I know. I did it because I thought that copy_character
Florian> should be the only function that knows which characters need
Florian> special treatment. If we decide to follow this rule, then
Florian> there are some more occurences of obstack_1grow that should
Florian> be changed. It would be more consistent IMHO.
Yep, I know too :). The fact that it's inlined matters too.