bayonne-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Bayonne-devel] ScriptInterp::getMember VS. ScriptCommand::getMember


From: David Sugar
Subject: Re: [Bayonne-devel] ScriptInterp::getMember VS. ScriptCommand::getMember
Date: Sat, 07 Oct 2006 07:41:28 -0400
User-agent: Thunderbird 1.5.0.7 (X11/20060913)

Are the attachements missing?

Zhang Le wrote:
These two getMember's behavior is different.
For example. for "register.sip"
ScriptInterp::getMember's result doesn't include the leading dot, ie. the
result is "sip"
ScriptCommand::getMember's result include the leading dot, ie. the result is
".sip"

Unfortunately, this difference is overlooked sometimes.
For example, in bayonne2-1.5.28 src/checks.cpp, chkSlog function assumes
ScriptCommand::getMember's result doesn't include the leading dot, thus
command like "slog.info" won't work.

Although we could fix the problem by modifying chkSlog(), I think the better
solution is make the behavior of the two getMember consistent with each
other.

So I made two patches, one for ccscript3-1.0.9, the other for bayonn2-1.5.29
.
These two patches could make ScriptCommand::getMember behave the same as
ScriptInterp::getMember, and solve all (at least I can't find any more) the
problems caused by this behavior change of ScriptCommand::getMember.
Please check the attachment.


------------------------------------------------------------------------

_______________________________________________
Bayonne-devel mailing list
address@hidden
http://lists.gnu.org/mailman/listinfo/bayonne-devel

reply via email to

[Prev in Thread] Current Thread [Next in Thread]