[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: (Fwd) [avr-libc-dev] [RFC] boot cleanup

From: Theodore A. Roth
Subject: Re: (Fwd) [avr-libc-dev] [RFC] boot cleanup
Date: Fri, 27 Feb 2004 16:21:51 -0800 (PST)

On Fri, 27 Feb 2004, E. Weddington wrote:

> > Hi,
> > 
> > The attached patch changes the bootloader example to show a more
> > efficient usage of the boot API. The example was taken from my working
> > xmodem bootloader code.
> > 
> > Also, I've removed redundant checks for eeprom and spm busy in the API
> > macros. These changes reduce the size of the example by about 30 bytes.
> > 
> > Finally, I've added *_safe() version of the boot_*() macros that contain
> > the eeprom and spm busy checks if anyone wants to use them.
> > 
> > Any objections for HEAD? I'm not sure if this should go into 1.0 since
> > it will most likely break existing code. If 1.0 users want to use this
> > version of the API, they can pull it from CVS.
> Looks good!
> One nit:
> In the example you declare the variable i as an int, and probably should be 
> uint16_t, you think?

Is SPM_PAGESIZE every going to be larger than 32K? If not, I doubt it 
matters as long as i is not an uint8_t.

Ted Roth

reply via email to

[Prev in Thread] Current Thread [Next in Thread]