[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: skip_ vs. skip_all_
From: |
Peter Rosin |
Subject: |
Re: skip_ vs. skip_all_ |
Date: |
Wed, 04 Jan 2012 19:48:32 +0100 |
User-agent: |
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:8.0) Gecko/20111105 Thunderbird/8.0 |
Stefano Lattarini skrev 2012-01-04 18:34:
> On 01/04/2012 03:57 PM, Peter Rosin wrote:
>> diff --git a/tests/defs b/tests/defs
>> index dbf0ff9..835788d 100644
>> --- a/tests/defs
>> +++ b/tests/defs
>> @@ -774,7 +774,8 @@ do
>> # Attempting to create an empty archive will actually not
>> # create the archive, but lib will output its version.
>> echo "$me: running $AR -out:defstest.lib"
>> - $AR -out:defstest.lib || skip_ "Microsoft \`lib' utility not
>> available"
>> + $AR -out:defstest.lib \
>> + || skip_all_ "Microsoft \`lib' utility not available"
>> ;;
>> makedepend)
>> echo "$me: running makedepend -f-"
>>
> This is the right fix. Should I apply it, or will you do so (with a proper
> git
> commit message, of course)?
Thanks for the feedback, I can push it, do you have any issues with the
below commit message?
Cheers,
Peter
test defs: skip all tests when the lib requirement isn't fulfilled
* tests/defs (lib): Use skip_all_ instead of skip_, in order to support
TAP-based test scripts.