Re: [FYI] {maint} maintcheck: avoid few spurious failures

[Ralf Wildenhues]

* Stefano Lattarini wrote on Mon, Jun 20, 2011 at 05:05:45PM CEST:
> * Makefile.am (sc_tests_plain_aclocal, sc_tests_plain_perl,
> sc_tests_plain_autoconf, sc_tests_plain_automake,
> sc_tests_plain_autoupate): Be stricter in matching an erroneous
> literal command, i.e., `aclocal', `automake', `perl', etc.

>  sc_tests_plain_automake:
> -     @if grep -v '^#' $(srcdir)/tests/*.test | grep -E ':[   
> ]*automake([^:]|$$)'; then \
> +     @if grep -v '^#' $(srcdir)/tests/*.test | grep -E ':[   
> ]*automake\>([^:]|$$)'; then \

The RE that was there before was there specifically to emulate the
nonportable '\>' construct.  Now, I'm not sure I should fight for using
Posix compatible regular expressions in maintainer-check rules (seems I
lost that battle earlier already), but if you require GNU grep, please
be consistent and remove the now-unneeded stuff afterwards and the -E.

>  sc_tests_plain_aclocal:
> -     @if grep -v '^#' $(srcdir)/tests/*.test | grep ':[      ]*aclocal'; 
> then \
> +     @if grep -v '^#' $(srcdir)/tests/*.test | grep ':[      ]*aclocal\>'; 
> then \
>         echo 'Do not run "aclocal" in the above tests.  Use "$$ACLOCAL" 
> instead.' 1>&2;  \
>         exit 1; \
>       fi

Thanks,
Ralf