[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] New tests on obsoleted usages of automake/autoconf macros.
From: |
Ralf Wildenhues |
Subject: |
Re: [PATCH] New tests on obsoleted usages of automake/autoconf macros. |
Date: |
Fri, 12 Nov 2010 20:44:37 +0100 |
User-agent: |
Mutt/1.5.20 (2010-08-04) |
* Stefano Lattarini wrote on Fri, Nov 12, 2010 at 08:37:14PM CET:
> On Friday 12 November 2010, Ralf Wildenhues wrote:
> > The easiest fix would be to grep for the lines in question, I guess.
> I agree. What about the attached patch? (It also makes the testcase
> simpler and shorter, BTW).
Leave out the $ in the grep patterns, in case grep assumes LF only.
OK with that change. But you could have left the other comparisons
intact; however you like.
Thanks,
Ralf
> Subject: [PATCH] Fix bug in test `backcompat6.test' (MSYS portability).
>
> * tests/backcompat6.test (Makefile.am): Grep the output from the
> test program, rather than comparing it with a file generated
> on-the-fly through the `echo' builtin. This prevents a spurious
> failure on MinGW/MSYS due to LF vs. CRLF line endings.
How about
* tests/backcompat6.test (Makefile.am): Grep output, to avoid newline
encoding differences on MSYS.