Re: [PATCH] New tests on obsoleted usages of automake/autoconf macros.

[Stefano Lattarini]

On Saturday 06 November 2010, Ralf Wildenhues wrote:
> * Stefano Lattarini wrote on Wed, Nov 03, 2010 at 07:12:27PM CET:
> > Pinging this patch again, following this:
> >  <http://lists.gnu.org/archive/html/automake-patches/2010-11/msg00003.html>
> > 
> > I've also re-based the patch off of latest maint, extended some checks a
> > little bit, fixed a typo in comments, and fixed some very minor and 
> > theoretic
> > portability problems (use of "test -z").
> > The updated patch is attached.
> 
> The patch is ok except I don't think the PACKAGE_URL part will work with
> Autoconf 2.62, it was added later only.
Yes, it works (tested), because we only check that it's empty if AC_INIT is
called with two arguments, and that was true also for older autoconf versions.
> You can look at Automake's own
> configure.ac for a workaround; the patch is OK with a fix to that end
> that you deem suitable.
I don't think a fix is needed here.
 
> When you post updated patches, then to avoid having to re-review the
> whole patch again you could additionally post an incremental patch.
> You can usually get one with something like
>   git diff address@hidden
> 
> right after committing the increment, or some
>   git diff address@hidden address@hidden
> 
> for some suitable $a and $b.  Thanks.
Will do (hopefully at least; just scold me again if I forgot!)

> [CUT]

Regards,
  Stefano