automake-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/7] Tests defs: various reorderings, some improvements.


From: Ralf Wildenhues
Subject: Re: [PATCH 1/7] Tests defs: various reorderings, some improvements.
Date: Thu, 11 Nov 2010 20:05:49 +0100
User-agent: Mutt/1.5.20 (2010-08-04)

* Stefano Lattarini wrote on Thu, Nov 11, 2010 at 01:00:47PM CET:
> On Thursday 11 November 2010, Ralf Wildenhues wrote:
> >
> > Thank for respinning.  The patches are ok then, but I think you should
> > take care that the newly-introduced `pwd` is replaced by the variable
> > you later introduce for this (in the later patch, of course).

> Which newly-introduced pwd?  There should be no such thing in these
> patches, if I'm not mistaken.

Mistake of mine, I overlooked that this one:

> @@ -390,7 +395,9 @@ case " $required " in
>      esac
>      # Libtool cannot cope with spaces in the build tree.  Our testsuite setup
>      # cannot cope with spaces in the source tree name for Libtool and gettext
> -    # tests.
> +    # tests.  Using just "`pwd`" for the check here is ok, since the further
> +    # temporary subdirectory where the test will be run is ensured not to
> +    # contain any space.
>      case $testsrcdir,`pwd` in
>        *\ * | *\        *) Exit 77;;
>      esac

is treated in 2/7.  Sorry about that.

Thanks,
Ralf



reply via email to

[Prev in Thread] Current Thread [Next in Thread]