Re: [PATCH 1/7] Tests defs: various reorderings, some improvements.

[Stefano Lattarini]

On Thursday 11 November 2010, Ralf Wildenhues wrote:
> * Stefano Lattarini wrote on Thu, Nov 11, 2010 at 12:37:23AM CET:
> > Well, the patch is "almost" just code reordering, with the very minor
> > exceptions that:
> > 
> >   1. in the older version, some error messages could be printed before
> >      `$me' was defined, so they couldn't use it; now `$me' is defined
> >      early, so those error messages has been amended to include it;
> > 
> >   2. in the older version, a test might be skipped from within code
> >      in `tests/defs' *after* the exit trap was installed, so a call
> >      to "Exit 77" was in order; now the skips only happens before the
> >      installation of the exit trap, so "exit 77" is enough;
> > 
> >   3. some comments has been slighty adjusted and extended, because the
> >      act of reordering the code suggested them to me.
> > 
> > Anyway, none of these additional "minor" changes is really required to
> > make the new `tests/defs.in' work correctly, so I agree that they should
> > have been done in follow-up patches.  I've respin and split my patch to
> > do so (see the attached four patches).
> 
> Thank for respinning.  The patches are ok then, but I think you should
> take care that the newly-introduced `pwd` is replaced by the variable
> you later introduce for this (in the later patch, of course).
Which newly-introduced pwd?  There should be no such thing in these
patches, if I'm not mistaken.

Regards,
  Stefano