Re: [PATCH] Testsuite: do not use `chmod -R' when cleaning up.

[Ralf Wildenhues]

* Stefano Lattarini wrote on Wed, Oct 07, 2009 at 02:10:04AM CEST:
> At Tuesday 06 October 2009, Ralf Wildenhues wrote:
> > Any reason against using
[...]
> > to avoid lots of forking in the "normal" case?
> No reason at all.  I just thought that avoiding forks was not important
> here.

Avoiding unnecessary overhead is always good; it's just that
optimization shouldn't be premature.

> I have amended and resent my patch.  I have also changed your
> fix sligthly, to make it even clearer (IMHO).

Thanks.  Applied to maint; will push soon.

Cheers,
Ralf

> Subject: [PATCH] Testsuite: do not use `chmod -R' when cleaning up.
> 
> * tests/Makefile.am (clean-local-check): Do not use `chmod -R' on
> the test directories, as that may change or try to change the mode
> of installed files: the test directory may contain symlinks to
> ltmain.sh files from a Libtool installation, and Solaris `chmod -R'
> touches symlink targets.  Instead, use the cleanup strategy used
> in distdir.am (which is also employed in tests/defs.in).