[PATCH] Testsuite: do not use `chmod -R' when cleaning up.

[Stefano Lattarini]

Hello automakers.

I see that the cleanup code in `tests/defs.in' (which for obvious
reasons must ensure that the all the subdirectories of the test
directory $testSubDir are writable, before trying to remove it) avoids
the use of `chmod -R'.  This behaviour was introduced in commit
d9bd0090cf471a088bc0119cd989c06a63d2408e, with the following
rationale:

 testsuite: do not change the mode of installed Libtool files.
 * tests/defs.in: Do not use `chmod -R' on the test directory, as
    that may change or try to change the mode of installed files:
    the test directory may contain symlinks to ltmain.sh files from
    a Libtool installation, and Solaris `chmod -R' touches symlink
    targets.  Instead, use the cleanup strategy used in distdir.am.

However, the target `clean-local-check' in `tests/Makefile.am' still
uses `chmod -R', which seems inconsistent (at best).

The attached patch should fix this.

Please note that I deliberately didn't add a NEWS entry about this
fix, as it is already present (even if the previous fix was in fact
incomplete):

  Bugs fixed in 1.11a:
  ...
  * Long standing bugs:
    ...
    - The testsuite does not try to change the mode of `ltmain.sh'
      files from a Libtool installation (symlinked to test directories)
      any more.
   ...

Regards,
   Stefano

0001-Testsuite-do-not-use-chmod-R-when-cleaning-up.patch
Description: Text Data