automake-patches
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: *_DATA containing blanks

From: Raja R Harinath
Subject: Re: *_DATA containing blanks
Date: Wed, 23 Jul 2003 15:04:29 -0500
User-agent: Gnus/5.1003 (Gnus v5.10.3) Emacs/21.3.50 (gnu/linux) 
Hi,

Ralf Corsepius <address@hidden> writes:

> Index: lib/am/distdir.am
[snip]
> -       case $$file in \
> +       case "$$file" in \

This delta isn't necessary.  You don't need to quote $file there.

[snip]
> +     done; else true; fi

I think we prefer ':' instead of 'true'.  Also, if the test case was

  if <test>; then <body> else : ; fi

and <body> was a single command, you can write

  <opposite of test> || <body>

It's the use of

  <test> && <body>

that is problematic.

- Hari
-- 
Raja R Harinath ------------------------------ address@hidden
reply via email to
[Prev in Thread] Current Thread [Next in Thread]