Re: AC_FC_CHECK_BOUNDS for Fortran array bounds checking.

[Eric Blake]

On 02/27/2011 09:10 AM, Ralf Wildenhues wrote:
> [ moving from autoconf@ to -patches@ ]
> 
> Hello,
> 
> here's a first macro to improve Fortran support in Autoconf.
> It uses Fortran 90 interface declarations, so a F77 version
> would have to be different (and I'm not quite sure whether
> this works as well in Fortran 77).  I only have access to a
> few of the listed compilers, the other flags are taken from
> manuals only.  I gather fixes will come from users over time.
> 
> OK to push?  Eve-Marie, OK to add your name and email to THANKS?

OK from my end, after addressing a nit.  In fact, since you are much
more familiar with Fortran than I am, I'm comfortable with you pushing
all of your recent Fortran patches if you don't get any better review
within a few days.

> +++ b/doc/autoconf.texi
> @@ -8246,6 +8246,16 @@ Fortran Compiler
>  message).
>  @end defmac
>  
> address@hidden AC_FC_CHECK_BOUNDS (@ovar{action-if-success}, 
> @ovar{action-if-failure})

Should this be listed as @dvar{action-if-failure, AC_MSG_FAILURE}...

> address@hidden
> +
> +The @code{AC_FC_CHECK_BOUNDS} macro tries to enable array bounds checking
> +in the Fortran compiler.  If successful, the @var{action-if-success}
> +is called and any needed flags are added to @code{FCFLAGS}.  Otherwise,
> address@hidden is called, which defaults to failing with an error
> +message.

...since it defaults in a fatal message?  Compare the recent patch to
AC_RUN_IFELSE.

-- 
Eric Blake   address@hidden    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature