Re: [PATCH] Calling AC_USE_SYSTEM_EXTENSIONS through several of its aliases should not issue a cryptic warning

[Eric Blake]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Stepan Kasal on 10/8/2008 11:11 AM:
> Hello,
>   it used to be usual to call
> 
> AC_GNU_SOURCE
> AC_USE_SYSTEM_EXTENSIONS
> 
> What do you think about the following patch?
> I see it slightly changes the semantics of AC_USE_SYSTEM_EXTENSIONS
> (the code is moved outside the outermost ac_defuned macro), do you
> think this is OK?
> 
> Or is it OK to commit?
> 
> Have a nice day,
>    Stepan
> 
> 
> * lib/autoconf/specific.m4 (AC_USE_SYSTEM_EXTENSIONS): Move
> the body to ...
> (_AC_USE_SYSTEM_EXTENSIONS): ... this new macro and require it
> from the original and ...
> (AC_GNU_SOURCE, AC_AIX, AC_MINIX): ... from all of these.

I think it looks sound; it ensures that the code is expanded only once,
instead of once for each variant spelling.  If you wouldn't mind, can you
also write up a NEWS item before applying?

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkjvTbAACgkQ84KuGfSFAYArzQCgnNmrCbhGzsXJ+b0Jz5GpZLQ0
DPYAn1uwUDKbS185B2epfRvu+qTsrGu4
=BNG7
-----END PGP SIGNATURE-----