|
From: | Paolo Bonzini |
Subject: | Re: [RFA] autotest speedup |
Date: | Fri, 05 Oct 2007 09:42:18 +0200 |
User-agent: | Thunderbird 2.0.0.6 (Macintosh/20070728) |
+####################### +### Shell functions ### +#######################Let's use m4_text_box here.
I used the "m4_text_box"-like comment so that it stands out in the code of autotest, not (only) to have a nice output in the testsuite.
And are we doing this in the optimal diversion? Do we need any m4sh support for writing portable shell functions?
We could use AS_REQUIRE_SHELL_FN instead, but that one is more useful if you don't want to emit the shell function unless necessary (which is not the case here).
I debated about making: m4_cond(TEST, [not,] VAL1, IF-[NOT-]VAL1, ...)
I think it is more complicated than necessary. The lazy m4_if is nice, though I'm not sure I like the name. Also, it adds one more "quoting rule" for the "non-initiated" (it took me already a while to get used not to quote m4_if arguments...).
Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |