|
From: | Paolo Bonzini |
Subject: | Re: [RFA] autotest speedup |
Date: | Thu, 04 Oct 2007 18:34:50 +0200 |
User-agent: | Thunderbird 2.0.0.6 (Macintosh/20070728) |
Paul Eggert wrote:
Paolo Bonzini <address@hidden> writes:+[test -n "$at_traceon" && at_check_newline "AS_ESCAPE([$1], [`\"])"])])[]dnlOne minor thing: at_check_newline is trace-specific (it doesn't merely check newlines; it does other stuff). So we might as well migrate the "test -n" business into at_check_newline, no? It'll make the code shorter and easier to read. And perhaps its name could be changed to "at_check_traceable" or something like that.
I disagree because you can omit the test completely if the nontraceability is determined at m4 time.
Anyway I have to rush so I'll commit tomorrow and wait for your opinion if any.
Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |