autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: fix AT_SETUP's sh-escaping


From: Ralf Wildenhues
Subject: Re: fix AT_SETUP's sh-escaping
Date: Wed, 8 Nov 2006 23:44:58 +0100
User-agent: Mutt/1.5.13 (2006-08-11)

* Paul Eggert wrote on Sat, Oct 28, 2006 at 01:06:17AM CEST:
> "Joel E. Denny" <address@hidden> writes:
> 
> > +2006-10-26  Joel E. Denny  <address@hidden>
> > +   and Stepan Kasal  <address@hidden>
> > +
> > +   Handle special characters in test case titles correctly.
> > +   * lib/autotest/general.m4 (AT_INIT): M4-quote and AS_ESCAPE AT_help_all
> > +   properly.
> > +   (AT_SETUP): M4-quote and AS_ESCAPE the title properly everywhere.
> > +   ...
> 
> Thanks, I installed that.

AFAICS this patch introduces nonportable sed scripts which cause tests
64 65 66 67 68 69 70 71 72 74 to fail on FreeBSD 6.1 (for a different
reason than they may have failed before :-).

OK to apply?  There's no need to avoid '\{1,\}' for portability, right?

Furthermore, test 76 (Macro with backslash) gets an UNEXPECTED PASS on
several systems (HP-UX, IRIX, OpenBSD, Solaris).  Not analyzed yet.

Cheers,
Ralf

2006-11-08  Ralf Wildenhues  <address@hidden>

        * tests/autotest.at (AT_CHECK_AT_TITLE): Fix non-portable sed
        scripts.

Index: tests/autotest.at
===================================================================
RCS file: /cvsroot/autoconf/autoconf/tests/autotest.at,v
retrieving revision 1.18
diff -u -r1.18 autotest.at
--- tests/autotest.at   27 Oct 2006 23:05:34 -0000      1.18
+++ tests/autotest.at   8 Nov 2006 22:28:12 -0000
@@ -257,11 +257,11 @@
 AT_CHECK([:])
 AT_CLEANUP
 ]], [$4], [], [], [],
-[AT_CHECK([[./micro-suite | sed -n "s/[^:]*: \(.*[^ \t]\)[ \t]*ok.*/\1/p"]],,
+[AT_CHECK([[./micro-suite | sed -n "s/[^:]*: \(.*[^     ]\)[    
]*ok.*/\1/p"]],,
 [[$3
 ]])
 AT_CHECK([[./micro-suite -l \
-             | sed -n "s/.*[0-9]\+: [^ \t]\+[ \t]\+\(.*[^ \t]\)[ \t]*/\1/p"]],,
+             | sed -n "s/.*[0-9]\{1,\}: [^      ]\{1,\}[        ]\{1,\}\(.*[^  
 ]\)[    ]*/\1/p"]],,
 [[$3
 ]])
 AT_CHECK([[sed -n "s/[^.]*\. \(.*\) ([^)]*): ok.*/\1/p" micro-suite.log]],,




reply via email to

[Prev in Thread] Current Thread [Next in Thread]