autoconf-patches
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Fix building autoconf.1


From: Paul Eggert
Subject: Re: Fix building autoconf.1
Date: Tue, 01 Feb 2005 16:28:54 -0800
User-agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.3 (gnu/linux)

Stepan Kasal <address@hidden> writes:

> Wouldn't it be enough to echo the command before executing it?
> When I look at Makefile.in, I see that Automake uses the technique on
> several places.  And, yes, it means the command is duplicated, but I
> think that after all it's less fragille that your clever rule set.

Perhaps you're right.  Another point is that my version allows
parallelism in the build, but perhaps that's not safe (who knows?  I
don't, and it's better to be safe if you don't know.)  I installed
this modified version of your patch.  Thanks.

2005-02-01  Paul Eggert  <address@hidden>

        * man/Makefile.am (.x.1): Go back to the simple solution, but take
        care to echo the commands, so the user knows what's going on.
        Modified from a suggestion by Stepan Kasal.

--- man/Makefile.am     1 Feb 2005 00:14:04 -0000       1.22
+++ man/Makefile.am     2 Feb 2005 00:22:19 -0000
@@ -50,9 +50,14 @@ $(srcdir)/config.sub.1:   $(top_srcdir)/
 SUFFIXES = .x .1
 
 .x.1:
-       @case $* in \
-         config.* | */config.*) ;; \
-         *) $(MAKE) $*-bin-prereq $*-tests-prereq;; \
+       @program=`expr "/$*" : '.*/\(.*\)'` && \
+       case $$program in \
+       config.*) ;; \
+       *) \
+         for dir in $(top_builddir)/bin $(top_builddir)/tests; do \
+           echo cd $$dir '&&' $(MAKE) $(AM_MAKEFLAGS) $$program && \
+           (cd $$dir && $(MAKE) $(AM_MAKEFLAGS) $$program) || exit; \
+         done;; \
        esac
        echo "Updating man page $@"
        
PATH="$(top_builddir)/address@hidden@$(top_srcdir)/address@hidden@$$PATH"; \
@@ -60,19 +65,4 @@ SUFFIXES = .x .1
        $(HELP2MAN) \
            --include=$*.x \
            --include=$(srcdir)/common.x \
-           --output=$@ `echo "$*" | sed 's,^$(srcdir)/,,'`
-
-
-# While building man page prerequisites, avoid explicit dependencies
-# on any file that is not distributed, so that installers do not
-# unnecessarily attempt to run $(HELP2MAN), a tool that they may not
-# have.
-
-$(dist_man_MANS:.1=-bin-prereq) $(dist_man_MANS:.1=-tests-prereq):
-       @$(MAKE) $(AM_MAKEFLAGS) \
-         builddir=$(top_builddir)/`expr 'X$@' : '.*-\([^-]*\)-prereq$$'` \
-         program=`expr '/$@' : '.*/\([^-]*\)'` \
-         implicit-man-prerequisites
-
-implicit-man-prerequisites:
-       cd $(builddir) && $(MAKE) $(AM_MAKEFLAGS) $(program)
+           --output=$@ `echo '$*' | sed 's,.*/,,'`




reply via email to

[Prev in Thread] Current Thread [Next in Thread]