[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: tvh-2-pathsep-cdpath.diff
From: |
Tim Van Holder |
Subject: |
Re: tvh-2-pathsep-cdpath.diff |
Date: |
17 Sep 2001 13:57:55 +0200 |
On Mon, 2001-09-17 at 11:16, Akim Demaille wrote:
>
> | -A simple colon is enough except for @code{zsh}, which prefers a leading
> | -dot:
> | +A simple path separator is enough except for @code{zsh}, which prefers a
> | +leading dot:
> |
> | @example
> | -zsh-3.1.6 % mkdir foo && (CDPATH=: cd foo)
> | +zsh-3.1.6 % mkdir foo && (address@hidden@} cd foo)
> | /tmp/foo
> | -zsh-3.1.6 % (CDPATH=:. cd foo)
> | +zsh-3.1.6 % (address@hidden@}. cd foo)
> | /tmp/foo
> | -zsh-3.1.6 % (CDPATH=.: cd foo)
> | +zsh-3.1.6 % (address@hidden@} cd foo)
> | zsh-3.1.6 %
> | @end example
>
> I'm not too much in favor of replacing `:' with PATH_SEPARATOR in the
> example and discussions about CDPATH, since it obfuscates what we are
> trying to teach, mentioning that using PATH_SEPARATOR is better style
> seems better to me. But I leave the final decision to you.
No, that's fine - I was just afraid people might simply look at the
example and not read further. I'll change it back.
> | +If it is not set, @command{autoconf} will detect the appropriate path
> | +separator for the build system and set the @code{PATH_SEPARATOR} output
> | +variable accordingly.
>
> You might intended to have a empty line here. And referring to
> autoconf here is somewhat misleading: configure does.
Right on both counts.
> | +On DJGPP systems, the @code{PATH_SEPARATOR} environment variable can be
> | +set to either @samp{:} or @samp{;} to control the path separator
> | address@hidden uses to set up certain environment variables (such as
> | address@hidden). Since this only works inside bash, you want autoconf to
> | +detect the regular @sc{dos} path separator (@samp{;}), so it can be safely
> | +substituted in files that may not support @samp{;} as path separator. So
> | either unset this variable or set it to @samp{;}.
>
> Please, keep the typography consistent: @command{autoconf},
> @command{bash} etc. You may chose between Autoconf the package here,
> or @command{configure} to be specific. I prefer the former, but chose
> what you want.
Will do.
> | -am_aux_dir=`CDPATH=:; cd $ac_aux_dir && pwd`
> | +am_aux_dir=`cd $ac_aux_dir && pwd`
>
> If you do this, please be sure to AC_PREREQ(2.50), since 2.13 does not
> enforce a proper CDPATH. So this code, and the other m4/*.m4 files,
> depends on at least 2.50.
I don't see why - this is used solely to build autoconf, and our
configure.ac already PREREQs a higher version.
> And you said, they come from Automake, so don't forget to fix them in
> CVS Automake, then update the Autoconf copies.
Ah - OK, so you only want unchanged copies of Automake files in our m4
dir. I'll submit a patch to Automake first then, and update autoconf to
use the patched CVS automake .m4 files.