[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: 18-autoscan-locations.patch
From: |
Pavel Roskin |
Subject: |
Re: 18-autoscan-locations.patch |
Date: |
Mon, 22 Jan 2001 13:21:13 -0500 (EST) |
On Mon, 22 Jan 2001, Akim Demaille wrote:
> Index: ChangeLog
> from Akim Demaille <address@hidden>
> * autoscan.pl (&wanted): Don't register `Makefile' when
> `Makefile.in' is present.
> Factor the simplification of $name.
> (&scan_makefile, &scan_sh_file): Instead of counting the number of
> occurrences where a program/makevar is wanted, register file:line.
> Adjust the verbose output.
> (&check_configure_ac): Specify where was found a macro requirement.
Please rewrite the last line in a better English. E.g.
"Report the location where the macro is required."
Still not ideal, but at least sounds better.
> + if ($macro !~ /[][]|^AC_CHECK_.*S/);
Not sure if Perl will understand it properly. I think the single "]" was
there for a reason. I skimmed through "man perlre" and couldn't find how
to quote square brackets inside character classes.
Otherwise Ok to apply.
Regards,
Pavel Roskin