Re: [Tinycc-devel] Do not load all referenced libraries, when linking a library

[grischka]

On 11.10.2023 11:34, Herman ten Brugge via Tinycc-devel wrote:
> On 10/10/23 17:37, Michael Matz wrote:
> > Only runtime loaders are required to follow DT_NEEDED.  link editors aren't.  
> > There's no distinction between emitting a shared lib or an executable.  (And 
> > for OUTPUT_MEMORY, which might be said to make tcc behave like a runtime 
> > loader, it's actually dlopen which does the necessary DT_NEEDED following).
> I understand. The original patch is ok.

I'd probably prefer just an "#if 0" around (also including the
DT_RPATH addition above btw), plus some comment why that
following DT_NEEDED tags is no longer relevant.

If that is what the conclusion from the discussion is ;)

Because as Detlef suggested, just the comment

+    /* do not load all referenced DLLs */
+    /* recursive loading can break linking of libraries */

with the code that it could refer to deleted doesn't make much sense
either, IMO.

-- grischka

>      Herman