[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 21/23] tests/qtest/usb-hcd: Remove the empty "init" tests
From: |
Michael Tokarev |
Subject: |
[PULL 21/23] tests/qtest/usb-hcd: Remove the empty "init" tests |
Date: |
Fri, 8 Sep 2023 12:55:18 +0300 |
From: Thomas Huth <thuth@redhat.com>
These tests do nothing additional compared to the other test,
so let's remove the empty functions to avoid wasting some few
precious test cycles here.
Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
tests/qtest/usb-hcd-uhci-test.c | 5 -----
tests/qtest/usb-hcd-xhci-test.c | 6 ------
2 files changed, 11 deletions(-)
diff --git a/tests/qtest/usb-hcd-uhci-test.c b/tests/qtest/usb-hcd-uhci-test.c
index 28751f53da..4446555f08 100644
--- a/tests/qtest/usb-hcd-uhci-test.c
+++ b/tests/qtest/usb-hcd-uhci-test.c
@@ -17,10 +17,6 @@
static QOSState *qs;
-static void test_uhci_init(void)
-{
-}
-
static void test_port(int port)
{
struct qhc uhci;
@@ -71,7 +67,6 @@ int main(int argc, char **argv)
return 0;
}
- qtest_add_func("/uhci/pci/init", test_uhci_init);
qtest_add_func("/uhci/pci/port1", test_port_1);
qtest_add_func("/uhci/pci/hotplug", test_uhci_hotplug);
if (qtest_has_device("usb-storage")) {
diff --git a/tests/qtest/usb-hcd-xhci-test.c b/tests/qtest/usb-hcd-xhci-test.c
index 80bc039446..0cccfd85a6 100644
--- a/tests/qtest/usb-hcd-xhci-test.c
+++ b/tests/qtest/usb-hcd-xhci-test.c
@@ -11,11 +11,6 @@
#include "libqtest-single.h"
#include "libqos/usb.h"
-
-static void test_xhci_init(void)
-{
-}
-
static void test_xhci_hotplug(void)
{
usb_test_hotplug(global_qtest, "xhci", "1", NULL);
@@ -54,7 +49,6 @@ int main(int argc, char **argv)
g_test_init(&argc, &argv, NULL);
- qtest_add_func("/xhci/pci/init", test_xhci_init);
qtest_add_func("/xhci/pci/hotplug", test_xhci_hotplug);
if (qtest_has_device("usb-uas")) {
qtest_add_func("/xhci/pci/hotplug/usb-uas", test_usb_uas_hotplug);
--
2.39.2
- [PULL 10/23] qga/: spelling fixes, (continued)
- [PULL 10/23] qga/: spelling fixes, Michael Tokarev, 2023/09/08
- [PULL 11/23] misc/other: spelling fixes, Michael Tokarev, 2023/09/08
- [PULL 12/23] block: spelling fixes, Michael Tokarev, 2023/09/08
- [PULL 13/23] hw/display/xlnx_dp: update comments, Michael Tokarev, 2023/09/08
- [PULL 14/23] qemu-options.hx: Rephrase the descriptions of the -hd* and -cdrom options, Michael Tokarev, 2023/09/08
- [PULL 15/23] docs tests: Fix use of migrate_set_parameter, Michael Tokarev, 2023/09/08
- [PULL 16/23] tests/qtest/test-hmp: Fix migrate_set_parameter xbzrle-cache-size test, Michael Tokarev, 2023/09/08
- [PULL 17/23] accel/tcg: Fix typo in translator_io_start() description, Michael Tokarev, 2023/09/08
- [PULL 18/23] trivial: Simplify the spots that use TARGET_BIG_ENDIAN as a numeric value, Michael Tokarev, 2023/09/08
- [PULL 19/23] hw/ppc: use g_free() in spapr_tce_table_post_load(), Michael Tokarev, 2023/09/08
- [PULL 21/23] tests/qtest/usb-hcd: Remove the empty "init" tests,
Michael Tokarev <=
- [PULL 20/23] target/ppc: use g_free() in test_opcode_table(), Michael Tokarev, 2023/09/08
- [PULL 22/23] hw/net/vmxnet3: Fix guest-triggerable assert(), Michael Tokarev, 2023/09/08
- [PULL 23/23] qxl: don't assert() if device isn't yet initialized, Michael Tokarev, 2023/09/08