[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 13/23] hw/display/xlnx_dp: update comments
From: |
Michael Tokarev |
Subject: |
[PULL 13/23] hw/display/xlnx_dp: update comments |
Date: |
Fri, 8 Sep 2023 12:55:10 +0300 |
From: Peter Maydell <peter.maydell@linaro.org>
Clarify somewhat misleading code comments.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
hw/display/xlnx_dp.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/hw/display/xlnx_dp.c b/hw/display/xlnx_dp.c
index 822355ecc6..43c7dd8e9c 100644
--- a/hw/display/xlnx_dp.c
+++ b/hw/display/xlnx_dp.c
@@ -380,13 +380,16 @@ static inline void xlnx_dp_audio_mix_buffer(XlnxDPState
*s)
static void xlnx_dp_audio_callback(void *opaque, int avail)
{
/*
- * Get some data from the DPDMA and compute these data.
- * Then wait for QEMU's audio subsystem to call this callback.
+ * Get the individual left and right audio streams from the DPDMA,
+ * and fill the output buffer with the combined stereo audio data
+ * adjusted by the volume controls.
+ * QEMU's audio subsystem will call this callback repeatedly;
+ * we return the data from the output buffer until it is emptied,
+ * and then we will read data from the DPDMA again.
*/
XlnxDPState *s = XLNX_DP(opaque);
size_t written = 0;
- /* If there are already some data don't get more data. */
if (s->byte_left == 0) {
s->audio_data_available[0] = xlnx_dpdma_start_operation(s->dpdma, 4,
true);
--
2.39.2
- [PULL 03/23] hexagon: spelling fixes, (continued)
- [PULL 03/23] hexagon: spelling fixes, Michael Tokarev, 2023/09/08
- [PULL 05/23] xen: spelling fix, Michael Tokarev, 2023/09/08
- [PULL 06/23] audio: spelling fixes, Michael Tokarev, 2023/09/08
- [PULL 04/23] riscv: spelling fixes, Michael Tokarev, 2023/09/08
- [PULL 07/23] include/: spelling fixes, Michael Tokarev, 2023/09/08
- [PULL 08/23] scripts/: spelling fixes, Michael Tokarev, 2023/09/08
- [PULL 09/23] tests/: spelling fixes, Michael Tokarev, 2023/09/08
- [PULL 10/23] qga/: spelling fixes, Michael Tokarev, 2023/09/08
- [PULL 11/23] misc/other: spelling fixes, Michael Tokarev, 2023/09/08
- [PULL 12/23] block: spelling fixes, Michael Tokarev, 2023/09/08
- [PULL 13/23] hw/display/xlnx_dp: update comments,
Michael Tokarev <=
- [PULL 14/23] qemu-options.hx: Rephrase the descriptions of the -hd* and -cdrom options, Michael Tokarev, 2023/09/08
- [PULL 15/23] docs tests: Fix use of migrate_set_parameter, Michael Tokarev, 2023/09/08
- [PULL 16/23] tests/qtest/test-hmp: Fix migrate_set_parameter xbzrle-cache-size test, Michael Tokarev, 2023/09/08
- [PULL 17/23] accel/tcg: Fix typo in translator_io_start() description, Michael Tokarev, 2023/09/08
- [PULL 18/23] trivial: Simplify the spots that use TARGET_BIG_ENDIAN as a numeric value, Michael Tokarev, 2023/09/08
- [PULL 19/23] hw/ppc: use g_free() in spapr_tce_table_post_load(), Michael Tokarev, 2023/09/08
- [PULL 21/23] tests/qtest/usb-hcd: Remove the empty "init" tests, Michael Tokarev, 2023/09/08
- [PULL 20/23] target/ppc: use g_free() in test_opcode_table(), Michael Tokarev, 2023/09/08
- [PULL 22/23] hw/net/vmxnet3: Fix guest-triggerable assert(), Michael Tokarev, 2023/09/08
- [PULL 23/23] qxl: don't assert() if device isn't yet initialized, Michael Tokarev, 2023/09/08