[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] tcg: Implement tcg_gen_shri2_i64()
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH v2] tcg: Implement tcg_gen_shri2_i64() |
|
Date: |
Mon, 25 Feb 2019 08:41:50 -0800 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 2/25/19 8:36 AM, David Hildenbrand wrote:
> On 25.02.19 17:34, Richard Henderson wrote:
>> On 2/25/19 7:42 AM, David Hildenbrand wrote:
>>> +void tcg_gen_shri2_i64(TCGv_i64 ret, TCGv_i64 al, TCGv_i64 ah, int64_t
>>> count)
>>
>> Actually, I now wonder if a better name might be tcg_gen_extract2_i64
>> (no other change to arguments, i.e. the "len" parameter that extract
>> has is fixed at 64).
>>
>> Thoughts?
>
> That is actually a good idea. Maybe add a comment regarding len fixed to 64.
>
> Shall I resend or do you want to fix it up?
I'll fix it up.
r~