[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 12/20] disas: nanoMIPS: Clean up handling of
From: |
Aleksandar Rikalo |
Subject: |
Re: [Qemu-devel] [PATCH v5 12/20] disas: nanoMIPS: Clean up handling of 16-bit logic instructions |
Date: |
Thu, 27 Dec 2018 13:42:09 +0000 |
> From: Aleksandar Markovic
> Sent: Thursday, December 27, 2018 2:18 PM
> To: Aleksandar Markovic; address@hidden; Aleksandar Rikalo
> Cc: address@hidden; Stefan Markovic
> Subject: Re: [PATCH v5 12/20] disas: nanoMIPS: Clean up handling of 16-bit
> logic instructions
>
> > From: Aleksandar Markovic <address@hidden>
> > Subject: [PATCH v5 12/20] disas: nanoMIPS: Clean up handling of 16-bit
> > logic instructions
>
> > Clean up handling of 16-bit logic nanoMIPS instructions:
>
> ...
> >
> > - return img::format("AND %s, %s", rs3, rt3);
> > + return img::format("AND[16] %s, %s", rs3, rt3);
> > }
>
> I wonder if this instruction should be displayed with two or three arguments
> (by design of this instruction, the
> destination is the same register as one of sources, but would it be more
> clear for end user to see three arguments,
> even if two of them are always the same?)
nanomips-linux-musl-objdump always shows three registers and generic mnemonic
AND (without [16]).
On the other hand, inline assembler accepts syntax with two registers or/and
instruction format specification.
We should decide whether we should follow objdump or assembler conventions.
In any case, the same rule should be applied consistently across this
disassembler.
Thanks,
Aleksandar Rikalo
>
> Aleksandar
>
- [Qemu-devel] [PATCH v5 00/20] disas: nanoMIPS: Clean up several issues, Aleksandar Markovic, 2018/12/26
- [Qemu-devel] [PATCH v5 01/20] disas: nanoMIPS: Fix preamble text in nanomips.* files, Aleksandar Markovic, 2018/12/26
- [Qemu-devel] [PATCH v5 09/20] disas: nanoMIPS: Name more functions in a more descriptive way, Aleksandar Markovic, 2018/12/26
- [Qemu-devel] [PATCH v5 07/20] disas: nanoMIPS: Fix an FP-related misnomer 2, Aleksandar Markovic, 2018/12/26
- [Qemu-devel] [PATCH v5 12/20] disas: nanoMIPS: Clean up handling of 16-bit logic instructions, Aleksandar Markovic, 2018/12/26
- [Qemu-devel] [PATCH v5 05/20] disas: nanoMIPS: Name some functions in a more descriptive way, Aleksandar Markovic, 2018/12/26
- [Qemu-devel] [PATCH v5 11/20] disas: nanoMIPS: Clean up handling of 48-bit instructions, Aleksandar Markovic, 2018/12/26
- [Qemu-devel] [PATCH v5 06/20] disas: nanoMIPS: Fix an FP-related misnomer 1, Aleksandar Markovic, 2018/12/26
- [Qemu-devel] [PATCH v5 08/20] disas: nanoMIPS: Fix an FP-related misnomer 3, Aleksandar Markovic, 2018/12/26
- [Qemu-devel] [PATCH v5 10/20] disas: nanoMIPS: Fix order of more invocations, Aleksandar Markovic, 2018/12/26
- [Qemu-devel] [PATCH v5 02/20] disas: nanoMIPS: Remove functions that are not used, Aleksandar Markovic, 2018/12/26
- [Qemu-devel] [PATCH v5 19/20] disas: nanoMIPS: Rename the decoder of 'gpr4.zero' gpr encoding type, Aleksandar Markovic, 2018/12/26
- [Qemu-devel] [PATCH v5 18/20] disas: nanoMIPS: Comment the decoder of 'gpr4' gpr encoding type, Aleksandar Markovic, 2018/12/26
- [Qemu-devel] [PATCH v5 16/20] disas: nanoMIPS: Comment the decoder of 'gpr3.src.store' gpr encoding type, Aleksandar Markovic, 2018/12/26
- [Qemu-devel] [PATCH v5 15/20] disas: nanoMIPS: Rename the decoder of 'gpr3.src.store' gpr encoding type, Aleksandar Markovic, 2018/12/26