qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v5 12/20] disas: nanoMIPS: Clean up handling of


From: Aleksandar Markovic
Subject: Re: [Qemu-devel] [PATCH v5 12/20] disas: nanoMIPS: Clean up handling of 16-bit logic instructions
Date: Thu, 27 Dec 2018 13:18:51 +0000

> From: Aleksandar Markovic <address@hidden>
> Subject: [PATCH v5 12/20] disas: nanoMIPS: Clean up handling of 16-bit logic 
> instructions

> Clean up handling of 16-bit logic nanoMIPS instructions:

...
> 
> -    return img::format("AND %s, %s", rs3, rt3);
> +    return img::format("AND[16] %s, %s", rs3, rt3);
> }

I wonder if this instruction should be displayed with two or three arguments 
(by design of this instruction, the destination is the same register as one of 
sources, but would it be more clear for end user to see three arguments, even 
if two of them are always the same?)

Aleksandar


reply via email to

[Prev in Thread] Current Thread [Next in Thread]