Re: [Qemu-devel] [PATCH 1/3] ui: install logo icons to $prefix/share/icons

[Daniel P . Berrangé]

On Wed, Dec 19, 2018 at 11:19:57AM +0100, Gerd Hoffmann wrote:
>   Hi,
> 
> > > How did you create the png files?
> > > Can you drop a script or Makefile for that into the ui/icons directory?
> > 
> > I used GIMP so that it created high quality antialiased pngs.
> 
> Ok, so that'll be hardly scriptable.
> A short README will do then I guess.
> 
> > > Should we commit them to git, or generate at build time?
> > > Is the tool used something we can expect to be installed?
> > 
> > I tried using ImageMagick to convert SVG to PNG but the results
> > were really poor compared to GIMP - very fuzzy. Running with
> > -verbose I can see it is invoking inkscape to atually do the
> > conversion, and it tells inkscape to export a small image which
> > it then resizes, hence the quality loss.
> 
> Tried to call inkscape directly?
> Having something scriptable would be nice.

I'll have a play with calling inkscape directly.

> But I'm fine with a README saying gimp gives good results too.
> 
> > The icons are small enough that we shouldn't really worry about
> > having pre-rendered icons in GIT IMHO. They're not ever going to
> > change unless we replace our logo again.
> 
> And inkscape as package build dependency wouldn't be nice either.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|