[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] ui: install logo icons to $prefix/share/ico
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH 1/3] ui: install logo icons to $prefix/share/icons |
Date: |
Wed, 19 Dec 2018 08:20:23 +0100 |
User-agent: |
NeoMutt/20180716 |
On Tue, Dec 18, 2018 at 02:26:27PM +0000, Daniel P. Berrangé wrote:
> QEMU currently installs loogs to $prefix/share/qemu/ which means no GUI
> toolkit or applications can find them by default.
>
> The accepted standards for desktop applications declare that application
> logos / icons should be installed under $prefix/share/icons, so use this
> directory location.
>
> Pre-rendered icons are provided at the standard sizes expected for GUI
> applications, along with the scalable SVG, to ensure maximum portability.
>
> Signed-off-by: Daniel P. Berrangé <address@hidden>
> ---
> Makefile | 13 ++++++++++++-
> configure | 2 ++
> ui/gtk.c | 17 +++++------------
> .../qemu_logo_no_text.svg => ui/icons/qemu.svg | 0
> ui/icons/qemu_128x128.png | Bin 0 -> 7761 bytes
> ui/icons/qemu_16x16.png | Bin 0 -> 751 bytes
> ui/icons/qemu_24x24.png | Bin 0 -> 1167 bytes
> ui/icons/qemu_256x256.png | Bin 0 -> 16216 bytes
> .../qemu-icon.bmp => ui/icons/qemu_32x32.bmp | Bin
> ui/icons/qemu_32x32.png | Bin 0 -> 1656 bytes
> ui/icons/qemu_48x48.png | Bin 0 -> 2604 bytes
> ui/icons/qemu_512x512.png | Bin 0 -> 34609 bytes
> ui/icons/qemu_64x64.png | Bin 0 -> 3588 bytes
How did you create the png files?
Can you drop a script or Makefile for that into the ui/icons directory?
Should we commit them to git, or generate at build time?
Is the tool used something we can expect to be installed?
cheers,
Gerd
Re: [Qemu-devel] [PATCH 0/3] Fix & improve icon display on GTK and SDL frontends, no-reply, 2018/12/26