|
From: | Paolo Bonzini |
Subject: | Re: [Qemu-devel] [PATCH v2 0/3] Fix strncpy() warnings for GCC8 new -Wstringop-truncation |
Date: | Tue, 18 Dec 2018 15:45:08 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 |
On 18/12/18 15:31, Michael S. Tsirkin wrote: > Do you happen to know why does it build fine with > Gcc 8.2.1? > > Reading the GCC manual it seems that > there is a "nostring" attribute that means > "might not be 0 terminated". > I think we should switch to that which fixes the warning > but also warns if someone tries to misuse these > as C-strings. > > Seems to be a better option, does it not? > > Using strpadcpy is clever and self-documenting, though. We have it already, so why not use it. Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |