[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 4/5] pvrdma: release ring object in case of an error
From: |
P J P |
Subject: |
[Qemu-devel] [PATCH 4/5] pvrdma: release ring object in case of an error |
Date: |
Tue, 11 Dec 2018 18:56:41 +0530 |
From: Prasad J Pandit <address@hidden>
create_cq and create_qp routines allocate ring object, but it's
not released in case of an error, leading to memory leakage.
Reported-by: Li Qiang <address@hidden>
Signed-off-by: Prasad J Pandit <address@hidden>
---
hw/rdma/vmw/pvrdma_cmd.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/hw/rdma/vmw/pvrdma_cmd.c b/hw/rdma/vmw/pvrdma_cmd.c
index ee2888259c..e8d99f29fa 100644
--- a/hw/rdma/vmw/pvrdma_cmd.c
+++ b/hw/rdma/vmw/pvrdma_cmd.c
@@ -337,7 +337,9 @@ static int create_cq(PVRDMADev *dev, union pvrdma_cmd_req
*req,
resp->hdr.err = rdma_rm_alloc_cq(&dev->rdma_dev_res, &dev->backend_dev,
cmd->cqe, &resp->cq_handle, ring);
- resp->cqe = cmd->cqe;
+ if (resp->hdr.err) {
+ g_free(ring);
+ }
out:
pr_dbg("ret=%d\n", resp->hdr.err);
@@ -490,6 +492,10 @@ static int create_qp(PVRDMADev *dev, union pvrdma_cmd_req
*req,
cmd->max_send_sge, cmd->send_cq_handle,
cmd->max_recv_wr, cmd->max_recv_sge,
cmd->recv_cq_handle, rings, &resp->qpn);
+ if (resp->hdr.err) {
+ g_free(rings);
+ goto out;
+ }
resp->max_send_wr = cmd->max_send_wr;
resp->max_recv_wr = cmd->max_recv_wr;
--
2.19.2
- [Qemu-devel] [PATCH 0/5] rdma: various issues in rdma/pvrdma backend, P J P, 2018/12/11
- [Qemu-devel] [PATCH 1/5] rdma: check that num_sge does not exceed MAX_SGE, P J P, 2018/12/11
- [Qemu-devel] [PATCH 2/5] pvrdma: add uar_read routine, P J P, 2018/12/11
- [Qemu-devel] [PATCH 4/5] pvrdma: release ring object in case of an error,
P J P <=
- Re: [Qemu-devel] [PATCH 4/5] pvrdma: release ring object in case of an error, Yuval Shaia, 2018/12/11
- Re: [Qemu-devel] [PATCH 4/5] pvrdma: release ring object in case of an error, Yuval Shaia, 2018/12/11
- Re: [Qemu-devel] [PATCH 4/5] pvrdma: release ring object in case of an error, P J P, 2018/12/11
- Re: [Qemu-devel] [PATCH 4/5] pvrdma: release ring object in case of an error, P J P, 2018/12/12
- Re: [Qemu-devel] [PATCH 4/5] pvrdma: release ring object in case of an error, Yuval Shaia, 2018/12/12
- Re: [Qemu-devel] [PATCH 4/5] pvrdma: release ring object in case of an error, Yuval Shaia, 2018/12/12
- Re: [Qemu-devel] [PATCH 4/5] pvrdma: release ring object in case of an error, P J P, 2018/12/12
[Qemu-devel] [PATCH 3/5] pvrdma: check number of pages when creating rings, P J P, 2018/12/11
[Qemu-devel] [PATCH 5/5] pvrdma: check return value from pvrdma_idx_ring_has_ routines, P J P, 2018/12/11