Re: [Qemu-devel] [RFC] hw/alpha/typhoon: Stop calling cpu_unassigned_access()

[Richard Henderson]

On 12/10/18 11:33 AM, Peter Maydell wrote:
> The typhoon MemoryRegionOps callbacks directly call
> cpu_unassigned_access(), presumably as the old-fashioned way
> to provoke a CPU exception.  This won't work since commit
> 6ad4d7eed05a1e235 when we switched Alpha over to the
> transaction_failed hook API, because now cpu_unassigned_access()
> is a no-op for Alpha.

Oops.

> Make the MemoryRegionOps callbacks use the read_with_attrs
> and write_with_attrs hooks, so they can signal a failure
> that should cause a CPU exception by returning MEMTX_ERROR.
> 
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> RFC because untested, since I don't have an alpha test image.
> 
>  hw/alpha/typhoon.c | 47 ++++++++++++++++++++++++++--------------------
>  1 file changed, 27 insertions(+), 20 deletions(-)

Tested-by: Richard Henderson <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>

and queued.  Thanks.


r~