[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 24/35] target/riscv: Move gen_arith_imm() dec
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 24/35] target/riscv: Move gen_arith_imm() decoding into trans_* functions |
|
Date: |
Wed, 31 Oct 2018 22:26:28 +0000 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 |
On 10/31/18 1:20 PM, Bastian Koppelmann wrote:
> +
> +#ifdef TARGET_RISCV64
> +static void gen_addiw(TCGv ret, TCGv arg1, TCGv arg2)
> +{
> + tcg_gen_add_tl(ret, arg1, arg2);
> + tcg_gen_ext32s_tl(ret, ret);
> +}
> +#endif
This should have been called gen_addw. It takes no immediate.
r~
- [Qemu-devel] [PATCH v3 34/35] target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64, (continued)
- [Qemu-devel] [PATCH v3 34/35] target/riscv: Splice remaining compressed insn pairs for riscv32 vs riscv64, Bastian Koppelmann, 2018/10/31
- [Qemu-devel] [PATCH v3 18/35] target/riscv: Convert quadrant 1 of RVXC insns to decodetree, Bastian Koppelmann, 2018/10/31
- [Qemu-devel] [PATCH v3 13/35] target/riscv: Convert RV64F insns to decodetree, Bastian Koppelmann, 2018/10/31
- [Qemu-devel] [PATCH v3 22/35] target/riscv: Remove manual decoding from gen_load(), Bastian Koppelmann, 2018/10/31
- [Qemu-devel] [PATCH v3 14/35] target/riscv: Convert RV32D insns to decodetree, Bastian Koppelmann, 2018/10/31
- [Qemu-devel] [PATCH v3 17/35] target/riscv: Convert quadrant 0 of RVXC insns to decodetree, Bastian Koppelmann, 2018/10/31
- [Qemu-devel] [PATCH v3 33/35] target/riscv: Splice fsw_sd and flw_ld for riscv32 vs riscv64, Bastian Koppelmann, 2018/10/31
- [Qemu-devel] [PATCH v3 24/35] target/riscv: Move gen_arith_imm() decoding into trans_* functions, Bastian Koppelmann, 2018/10/31
- [Qemu-devel] [PATCH v3 31/35] target/riscv: Convert @cs_2 insns to share translation functions, Bastian Koppelmann, 2018/10/31
- [Qemu-devel] [PATCH v3 29/35] target/riscv: Remove gen_system(), Bastian Koppelmann, 2018/10/31
- [Qemu-devel] [PATCH v3 27/35] target/riscv: Remove manual decoding of RV32/64M insn, Bastian Koppelmann, 2018/10/31
- [Qemu-devel] [PATCH v3 28/35] target/riscv: Rename trans_arith to gen_arith, Bastian Koppelmann, 2018/10/31
- [Qemu-devel] [PATCH v3 23/35] target/riscv: Remove manual decoding from gen_store(), Bastian Koppelmann, 2018/10/31