Re: [Qemu-devel] Question: Perfecting checkpatch.pl

[Peter Maydell]

On 31 October 2018 at 12:00, Daniel P. Berrangé <address@hidden> wrote:
> On Tue, Oct 30, 2018 at 12:35:15PM +0000, Aleksandar Markovic wrote:
>> Perhaps checkpatch.pl should make sure the commit messages do not contain 
>> "address@hidden" and "Reviewed-off-by"?
>>
>> $ git log | grep address@hidden
>>     Signed-off-by: Michael S. Tsirkin <address@hidden>
>>     Signed-off-by: Ronald Hecht <address@hidden>
>>     Signed-off-by: Justin Chevrier <address@hidden>
>>     Signed-off-by: Justin Chevrier <address@hidden>
>>     Signed-off-by: Justin Chevrier <address@hidden>
>
> This makes sense...
>
>>
>> $ git log | grep Reviewed-off-by
>>     Reviewed-off-by: Pavel Dovgalyuk <address@hidden>
>>     Reviewed-off-by: Anthony Liguori <address@hidden>
>
> but I'm not convinced it is worth doing this, because the set of
> mistakes people have made is enourmous, so it turns into a game
> of whack-a-mole.

You could have checkpatch whitelist the sensible ones:

>    3127 Acked-by
>    1834 Reported-by
>   30991 Reviewed-by
>   97837 Signed-off-by
>     660 Suggested-by
>    1951 Tested-by

and warn about the rest...

thanks
-- PMM