Re: [Qemu-devel] Question: Perfecting checkpatch.pl

[Philippe Mathieu-Daudé]

On 30/10/18 13:35, Aleksandar Markovic wrote:
> Perhaps checkpatch.pl should make sure the commit messages do not contain 
> "address@hidden" and "Reviewed-off-by"?
>
> $ git log | grep address@hidden
>      Signed-off-by: Michael S. Tsirkin <address@hidden>
>      Signed-off-by: Ronald Hecht <address@hidden>
>      Signed-off-by: Justin Chevrier <address@hidden>
>      Signed-off-by: Justin Chevrier <address@hidden>
>      Signed-off-by: Justin Chevrier <address@hidden>

Having a check for that is a good idea, but I don't think checkpatch 
would help, these incorrect emails only appear once maintainer applied 
patches, maybe the good place to check would be Peter's magic scripts, see:
https://git.linaro.org/people/peter.maydell/misc-scripts.git/tree/apply-pullreq?id=eeb001fcc1aabd8f077cd2846724120a3aa8f962#n118

Those emails also entered the tree:

hw/usb/hcd-ehci.c:4: * Copyright(c) 2008  Emutex Ltd. (address@hidden)
include/qemu/pmem.h:6: * Author: Haozhong Zhang <address@hidden>

> $ git log | grep Reviewed-off-by
>      Reviewed-off-by: Pavel Dovgalyuk <address@hidden>
>      Reviewed-off-by: Anthony Liguori <address@hidden>
>
> Aleksandar