Re: [Qemu-devel] [PATCH] qapi: add info about reset to SHUTDOWN event

[Dominik Csapak]

On 10/17/18 4:43 PM, Paolo Bonzini wrote:
> On 17/10/2018 15:54, Eric Blake wrote:
> > > So the problem with shutdown_caused_by_guest is that you get the same
> > > value for both guest reset and guest shutdown.  Could we instead just
> > > pass the ShutdownCause in the event (similar to what was proposed even
> > > when discussing commit 08fba7ac9b618516a5f1d096f78a7e2837fe0594)?
> >
> > Indeed, it sounds like we are now at the point where we want to do
> > precisely that - expose more fine-grained details by adding
> > ShutdownCause as a QAPI enum, rather than just adding another bool per
> > reason.
>
> So should we split HOST_QMP into HOST_QMP_{SYSTEM_RESET,QUIT} and add
> the ShutdownCause instead of was-reset?
>
> Paolo

this would work for us, should i send patches for this?
i would (roughly) do this:

move shutdowncause to qapi json
split host_qmp into system_reset and quit
and add the shutdowncause to the shutdown event
fix iotests

with kind regards
Dominik