|
From: | Eric Blake |
Subject: | Re: [Qemu-devel] [PATCH] qapi: add info about reset to SHUTDOWN event |
Date: | Wed, 17 Oct 2018 08:54:23 -0500 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 |
On 10/17/18 5:58 AM, Paolo Bonzini wrote:
- qapi_event_send_shutdown(shutdown_caused_by_guest(request)); + qapi_event_send_shutdown(shutdown_caused_by_guest(request), + shutdown_was_reset);So the problem with shutdown_caused_by_guest is that you get the same value for both guest reset and guest shutdown. Could we instead just pass the ShutdownCause in the event (similar to what was proposed even when discussing commit 08fba7ac9b618516a5f1d096f78a7e2837fe0594)?
Indeed, it sounds like we are now at the point where we want to do precisely that - expose more fine-grained details by adding ShutdownCause as a QAPI enum, rather than just adding another bool per reason.
-- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
[Prev in Thread] | Current Thread | [Next in Thread] |