Re: [Qemu-devel] [PATCH 05/15] hw/sh4/sh_pci: Use DeviceState::realize rather than SysBusDevice::init

[Marcel Apfelbaum]

Hi Philippe, Peter

On 10/2/18 10:59 PM, Philippe Mathieu-Daudé wrote:
> On 10/2/18 3:13 PM, Peter Maydell wrote:
> > On 1 October 2018 at 23:09, Philippe Mathieu-Daudé <address@hidden> wrote:
> > > Move from the legacy SysBusDevice::init method to using DeviceState::realize.
> > Comment says DeviceState::realize but the code is using
> > PCIDevice::realize ?
> >
> > I didn't realize pci devices had their own realize method:
> > what's the difference between it and plain old DeviceState::realize,

PCIDevice:realize handles PCI specific "realization" tasks:
* setup of the PCI configuration space
* PCI BARs configuration
* MSI initalization
*...

The PCIDevice's DeviceState::realize function named 'pci_qdev_realize'
calls PCIDevice:realize after it runs some generic initialization code.

It is possible we have this design so we would be able to move from
"qdev" to QOM.

Thanks,
Marcel

> > which they also have, since PCIDeviceClass inherits from DeviceClass ?
> Cc'ing Michael and Marcel.